Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding +inf bucket exemplar #1088

Closed
wants to merge 4 commits into from
Closed

Adding +inf bucket exemplar #1088

wants to merge 4 commits into from

Conversation

arun-shopify
Copy link
Contributor

  • explicitly add +inf bucket, if there is an exemplar for it.
  • If there are multiple exemplars outside of the max bucket bound, choose one for the +inf bucket and end the loop.

@kakkoyun
Copy link
Member

Hey @arun-shopify, it would be nice to open an issue to describe your problem and need before sending the PR. Maybe we could have discussed the details. Could you please explain your motivation in the PR description?

@arun-shopify
Copy link
Contributor Author

@kakkoyun hey sorry, this was supposed to be a PR to our fork (before making a PR here), I opened it in the main repo by mistake. But here is the actual problem I am trying to address: open-telemetry/opentelemetry-collector-contrib#9945 TLDR; Prometheus exporter in Open telemetry collector panics when it finds an exemplar that is outside of the bucket bounds. Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arun-shopify @kakkoyun