Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation around what constructors do #1125

Merged
merged 1 commit into from Sep 12, 2022

Commits on Sep 5, 2022

  1. Clarify documentation around what constructors do

    The wording of the documentation is slightly misleading. Before this
    commit, it says that the returned collectors are "already registered".
    This could be interpreted in two ways, one could think that promauto
    keeps some sort of cache of already registered Collectors that are
    returned by this package, and the other way is that the Collectors
    constructed are registered before being returned. What is actually
    happening is the latter, and the wording after this PR leaves no room to
    think that the former could be the case.
    
    Signed-off-by: Rafael Franco <me@rafaelfranco.es>
    donotnoot committed Sep 5, 2022
    Copy the full SHA
    700a94f View commit details
    Browse the repository at this point in the history