Cleanup proto use in tests #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/cleanup_tests
branch
from
71a1761
to
fa346ad
Compare
Switch tests over to new proto libary, eliminating the direct dependency on the old proto library. Note the indirect requirement is still needed due to upstream use by the client_model package. Related: #1175 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/cleanup_tests
branch
from
fa346ad
to
6a93bfe
Compare
|
Note, it would be useful to add prometheus/client_model#64, so we can use |
bwplotka
reviewed
May 3, 2023
| @@ -16,6 +15,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/golang/protobuf v1.5.3 // indirect | |||
There was a problem hiding this comment.
Yea, there's some circular dependencies to cleanup.
|
Oops, I should have put this in draft, I actually got the client_model fixed up. |
renovate bot
added a commit
to open-feature/flagd
that referenced
this pull request
Jun 15, 2023
….0 (#709) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.15.1` -> `v1.16.0` | --- ### Release Notes <details> <summary>prometheus/client_golang</summary> ### [`v1.16.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.16.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.15.1...v1.16.0) #### What's Changed - \[BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. [#​1252](https://togithub.com/prometheus/client_golang/issues/1252) - \[BUGFIX] api: Fix undefined execution order in return statements. [#​1260](https://togithub.com/prometheus/client_golang/issues/1260) - \[BUGFIX] native histograms: Fix bug in bucket key calculation. [#​1279](https://togithub.com/prometheus/client_golang/issues/1279) - \[ENHANCEMENT] Reduce constrainLabels allocations for all metrics. [#​1272](https://togithub.com/prometheus/client_golang/issues/1272) - \[ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. [#​1278](https://togithub.com/prometheus/client_golang/issues/1278) - \[ENHANCEMENT] promlint: Improve metricUnits runtime. [#​1286](https://togithub.com/prometheus/client_golang/issues/1286) <details> <summary> Commits </summary> - Merge v1.15 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1250 - Switch to POST for LabelNames, Series, and QueryExemplars to DoGetFallback by [@​jacksontj](https://togithub.com/jacksontj) in [prometheus/client_golang#1252 - ✏️ \[collectors]: fix typo in test assertion by [@​vegerot](https://togithub.com/vegerot) in [prometheus/client_golang#1153 - Added interactive tutorial \[kubeCon] by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1255 - Fixed tutorial. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1256 - Bump golang.org/x/sys from 0.6.0 to 0.7.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1265 - Cleanup proto use in tests by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1264 - Fix tutorial on WSL-based systems by [@​marevers](https://togithub.com/marevers) in [prometheus/client_golang#1257 - Fix undefined execution order in return statements by [@​PiotrLewandowski323](https://togithub.com/PiotrLewandowski323) in [prometheus/client_golang#1260 - Merge release 1.15.1 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1267 - GitHub Workflows security hardening by [@​sashashura](https://togithub.com/sashashura) in [prometheus/client_golang#1180 - add process start time header to client_golang prometheus by [@​logicalhan](https://togithub.com/logicalhan) in [prometheus/client_golang#1278 - Fix bug in bucket key calculation by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1279 - Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1283 - Reduce constrainLabels allocations by [@​khasanovbi](https://togithub.com/khasanovbi) in [prometheus/client_golang#1272 - added circleci as gh action YAML by [@​krishnaduttPanchagnula](https://togithub.com/krishnaduttPanchagnula) in [prometheus/client_golang#1281 - Improve metricUnits runtime by [@​avlitman](https://togithub.com/avlitman) in [prometheus/client_golang#1286 - Moving fully to GH actions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1288 - Fix docstring references to renamed native histogram fields / functions. by [@​juliusv](https://togithub.com/juliusv) in [prometheus/client_golang#1290 - Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier contributions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1289 - </details> #### New Contributors * @​vegerot made their first contributi[prometheus/client_golang#1153 * @​marevers made their first contributi[prometheus/client_golang#1257 * @​PiotrLewandowski323 made their first contributi[prometheus/client_golang#1260 * @​sashashura made their first contributi[prometheus/client_golang#1180 * @​logicalhan made their first contributi[prometheus/client_golang#1278 * @​khasanovbi made their first contributi[prometheus/client_golang#1272 * @​krishnaduttPanchagnula made their first contributi[prometheus/client_golang#1281 * @​avlitman made their first contributi[prometheus/client_golang#1286 **Full Changelog**: prometheus/client_golang@v1.15.1...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjExNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/hcloud-cloud-controller-manager
that referenced
this pull request
Jun 16, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.15.1` -> `v1.16.0` | --- ### Release Notes <details> <summary>prometheus/client_golang</summary> ### [`v1.16.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.16.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.15.1...v1.16.0) #### What's Changed - \[BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. [#​1252](https://togithub.com/prometheus/client_golang/issues/1252) - \[BUGFIX] api: Fix undefined execution order in return statements. [#​1260](https://togithub.com/prometheus/client_golang/issues/1260) - \[BUGFIX] native histograms: Fix bug in bucket key calculation. [#​1279](https://togithub.com/prometheus/client_golang/issues/1279) - \[ENHANCEMENT] Reduce constrainLabels allocations for all metrics. [#​1272](https://togithub.com/prometheus/client_golang/issues/1272) - \[ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. [#​1278](https://togithub.com/prometheus/client_golang/issues/1278) - \[ENHANCEMENT] promlint: Improve metricUnits runtime. [#​1286](https://togithub.com/prometheus/client_golang/issues/1286) <details> <summary> Commits </summary> - Merge v1.15 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1250 - Switch to POST for LabelNames, Series, and QueryExemplars to DoGetFallback by [@​jacksontj](https://togithub.com/jacksontj) in [prometheus/client_golang#1252 - ✏️ \[collectors]: fix typo in test assertion by [@​vegerot](https://togithub.com/vegerot) in [prometheus/client_golang#1153 - Added interactive tutorial \[kubeCon] by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1255 - Fixed tutorial. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1256 - Bump golang.org/x/sys from 0.6.0 to 0.7.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1265 - Cleanup proto use in tests by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1264 - Fix tutorial on WSL-based systems by [@​marevers](https://togithub.com/marevers) in [prometheus/client_golang#1257 - Fix undefined execution order in return statements by [@​PiotrLewandowski323](https://togithub.com/PiotrLewandowski323) in [prometheus/client_golang#1260 - Merge release 1.15.1 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1267 - GitHub Workflows security hardening by [@​sashashura](https://togithub.com/sashashura) in [prometheus/client_golang#1180 - add process start time header to client_golang prometheus by [@​logicalhan](https://togithub.com/logicalhan) in [prometheus/client_golang#1278 - Fix bug in bucket key calculation by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1279 - Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1283 - Reduce constrainLabels allocations by [@​khasanovbi](https://togithub.com/khasanovbi) in [prometheus/client_golang#1272 - added circleci as gh action YAML by [@​krishnaduttPanchagnula](https://togithub.com/krishnaduttPanchagnula) in [prometheus/client_golang#1281 - Improve metricUnits runtime by [@​avlitman](https://togithub.com/avlitman) in [prometheus/client_golang#1286 - Moving fully to GH actions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1288 - Fix docstring references to renamed native histogram fields / functions. by [@​juliusv](https://togithub.com/juliusv) in [prometheus/client_golang#1290 - Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier contributions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1289 - </details> #### New Contributors * @​vegerot made their first contributi[prometheus/client_golang#1153 * @​marevers made their first contributi[prometheus/client_golang#1257 * @​PiotrLewandowski323 made their first contributi[prometheus/client_golang#1260 * @​sashashura made their first contributi[prometheus/client_golang#1180 * @​logicalhan made their first contributi[prometheus/client_golang#1278 * @​khasanovbi made their first contributi[prometheus/client_golang#1272 * @​krishnaduttPanchagnula made their first contributi[prometheus/client_golang#1281 * @​avlitman made their first contributi[prometheus/client_golang#1286 **Full Changelog**: prometheus/client_golang@v1.15.1...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/hetznercloud/hcloud-cloud-controller-manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjExNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono
added a commit
to cozy/cozy-stack
that referenced
this pull request
Jun 19, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.15.1` -> `v1.16.0` | --- ### Release Notes <details> <summary>prometheus/client_golang</summary> ### [`v1.16.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.16.0) #### What's Changed - \[BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. [#​1252](https://togithub.com/prometheus/client_golang/issues/1252) - \[BUGFIX] api: Fix undefined execution order in return statements. [#​1260](https://togithub.com/prometheus/client_golang/issues/1260) - \[BUGFIX] native histograms: Fix bug in bucket key calculation. [#​1279](https://togithub.com/prometheus/client_golang/issues/1279) - \[ENHANCEMENT] Reduce constrainLabels allocations for all metrics. [#​1272](https://togithub.com/prometheus/client_golang/issues/1272) - \[ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. [#​1278](https://togithub.com/prometheus/client_golang/issues/1278) - \[ENHANCEMENT] promlint: Improve metricUnits runtime. [#​1286](https://togithub.com/prometheus/client_golang/issues/1286) <details> <summary> Commits </summary> - Merge v1.15 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1250 - Switch to POST for LabelNames, Series, and QueryExemplars to DoGetFallback by [@​jacksontj](https://togithub.com/jacksontj) in [prometheus/client_golang#1252 - ✏️ \[collectors]: fix typo in test assertion by [@​vegerot](https://togithub.com/vegerot) in [prometheus/client_golang#1153 - Added interactive tutorial \[kubeCon] by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1255 - Fixed tutorial. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1256 - Bump golang.org/x/sys from 0.6.0 to 0.7.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1265 - Cleanup proto use in tests by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1264 - Fix tutorial on WSL-based systems by [@​marevers](https://togithub.com/marevers) in [prometheus/client_golang#1257 - Fix undefined execution order in return statements by [@​PiotrLewandowski323](https://togithub.com/PiotrLewandowski323) in [prometheus/client_golang#1260 - Merge release 1.15.1 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1267 - GitHub Workflows security hardening by [@​sashashura](https://togithub.com/sashashura) in [prometheus/client_golang#1180 - add process start time header to client_golang prometheus by [@​logicalhan](https://togithub.com/logicalhan) in [prometheus/client_golang#1278 - Fix bug in bucket key calculation by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1279 - Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1283 - Reduce constrainLabels allocations by [@​khasanovbi](https://togithub.com/khasanovbi) in [prometheus/client_golang#1272 - added circleci as gh action YAML by [@​krishnaduttPanchagnula](https://togithub.com/krishnaduttPanchagnula) in [prometheus/client_golang#1281 - Improve metricUnits runtime by [@​avlitman](https://togithub.com/avlitman) in [prometheus/client_golang#1286 - Moving fully to GH actions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1288 - Fix docstring references to renamed native histogram fields / functions. by [@​juliusv](https://togithub.com/juliusv) in [prometheus/client_golang#1290 - Fixed README & CHANGELOG; Added fmt makefile command (+bingo) for easier contributions. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1289 - </details> #### New Contributors * @​vegerot made their first contributi[prometheus/client_golang#1153 * @​marevers made their first contributi[prometheus/client_golang#1257 * @​PiotrLewandowski323 made their first contributi[prometheus/client_golang#1260 * @​sashashura made their first contributi[prometheus/client_golang#1180 * @​logicalhan made their first contributi[prometheus/client_golang#1278 * @​khasanovbi made their first contributi[prometheus/client_golang#1272 * @​krishnaduttPanchagnula made their first contributi[prometheus/client_golang#1281 * @​avlitman made their first contributi[prometheus/client_golang#1286 **Full Changelog**: prometheus/client_golang@v1.15.1...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMjYuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch tests over to new proto libary, eliminating the direct dependency on the old proto library. Note the indirect requirement is still needed due to upstream use by the client_model package.
Related: #1175