Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocollector: Add regex option to allow collection of debug runtime metrics #1389

Merged
merged 1 commit into from
Apr 8, 2024
Merged

gocollector: Add regex option to allow collection of debug runtime metrics #1389

merged 1 commit into from
Apr 8, 2024

Conversation

ArthurSens
Copy link
Member

@ArthurSens ArthurSens commented Nov 23, 2023 •
edited

At the same time, it also solves the linting problem we're getting on main

@kakkoyun
Copy link
Member

This is a quick easy fix, but maybe we could extend the Go collector to allowList debug metrics instead(Consequentially we'd start using the withDebugMetrics method)?

👍

@ArthurSens ArthurSens changed the title chore: Fix lint issue 'withDebugMetrics unused' gocollector: Add regex option to allow collection of debug runtime metrics Nov 29, 2023
@ArthurSens ArthurSens marked this pull request as draft November 29, 2023 19:18
@ArthurSens ArthurSens mentioned this pull request Jan 17, 2024
Closed
@kakkoyun
Copy link
Member

@ArthurSens, shall we revive this?

@ArthurSens
Copy link
Member Author

Yeah, it's on my list for quite a while now and I don't even remember what blocked me 😓

I'll try to get back to this at some point this week

This was referenced Mar 28, 2024
Open
Closed
@ArthurSens
Copy link
Member Author

Alright, finally found time to come back to this :)

I had to modify the approach a bit after #1476. I'm now generating the withDebugMetrics() function with the script that @SachinSahu431 created.

There aren't any debug metrics for older debug metrics, so I've updated the script to also generate the function even if empty.

@ArthurSens ArthurSens marked this pull request as ready for review March 30, 2024 20:09
ArthurSens
ArthurSens commented Mar 30, 2024
View reviewed changes
prometheus/collectors/go_collector_go120_test.go Outdated
Comment on lines 33 to 35
"go_gc_cycles_automatic_gc_cycles_total",
"go_gc_cycles_forced_gc_cycles_total",
"go_gc_cycles_total_gc_cycles_total",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running the script, the order changed 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metrics were not sorted in the previous files

#1483 (comment)

@ArthurSens ArthurSens mentioned this pull request Mar 30, 2024
Merged
@ArthurSens
gocollector: Add regex option to allow collection of debug runtime me…
0f50003 
…trics

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
@ArthurSens ArthurSens merged commit e133e49 into main Apr 8, 2024
10 checks passed
@ArthurSens ArthurSens deleted the fix-lint-issue branch April 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachinSahu431 SachinSahu431 SachinSahu431 left review comments

@kakkoyun kakkoyun kakkoyun approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArthurSens @kakkoyun @SachinSahu431