Allocate constrain label values on stack, not heap for performance #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnshulMalik
force-pushed
the
constrain_heap
branch
from
3c53dc1
to
84a50f9
Compare
AnshulMalik
changed the title
Signed-off-by: Anshul <malikanshul29@gmail.com>
AnshulMalik
force-pushed
the
constrain_heap
branch
from
84a50f9
to
36d018f
Compare
|
Hey 👋 , pardon my ignorance, could you update your PR description mentioning how this change improves performance? I saw the title mentions that we're now allocating label values on the stack instead oh the heap, but I couldn't understand why that happens. Does it make sense to share a pprof profile or benchmarks? |
|
Hey, this PR accomplishes similar thing, I'll close the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.