Fix testutil metric comparison #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2018 15:48
Signed-off-by: beorn7 <beorn@soundcloud.com>
reflect.DeepEqual is not suitable for zero occurrences of repeated proto messages. This changes the comparison to act on the string representation of proto messages. Signed-off-by: beorn7 <beorn@soundcloud.com>
beorn7
force-pushed
the
beorn7/testing
branch
from
5b16050
to
86702ea
Compare
|
@beorn7 great thanks. That seems to fix the original bug which I had resolved by just using I can confirm at least a I can update the original issue or open a new one. If the latter then this looks to have resolved the original problem 👍 |
|
With this PR, there is no DeepEqual anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494.
@philipgough thanks for reporting, please have a look.
@brancz I think the "upstream" code for the testutil package is gone from KSM by now. So no action required there, I guess.