Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WriteHeader call to Flush #634

Merged
merged 1 commit into from Aug 20, 2019
Merged

Add WriteHeader call to Flush #634

merged 1 commit into from Aug 20, 2019

Commits on Aug 19, 2019

  1. Add WriteHeader call to Flush 

    Flush is another of the methods that will call WriteHeader if it
hasn't happened yet. Since we want to call observeWriteHeader (if
set), we need to do the WriteHeader call already here, similar to what
we have done in Write and ReadFrom.

This commit also adds comments explaining the above to not tempt
developers to remove the WriteHeader call.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Aug 19, 2019
    Copy the full SHA
    ad58180 View commit details
    Browse the repository at this point in the history