Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle empty job and label values #752

Merged
merged 1 commit into from May 14, 2020
Merged

Properly handle empty job and label values #752

merged 1 commit into from May 14, 2020

Commits on May 13, 2020

  1. Properly handle empty job and label values 

    An empty job name was always an error, but it was previously only
detected when pushing to the PGW and receiving an error. With this
commit, the error is detected before pushing.

An empty label value should have been OK but was encoded in a way that
couldn't be pushed to the
PGW. Cf. prometheus/pushgateway#344 . This
commit changes the creation of the path in the URL so that it works
with empty label values.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed May 13, 2020
    Copy the full SHA
    389d3c3 View commit details
    Browse the repository at this point in the history