Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exemplar support for const histogram #986

Merged
merged 7 commits into from Mar 17, 2022
Merged

Add exemplar support for const histogram #986

merged 7 commits into from Mar 17, 2022

Commits on Mar 7, 2022

  1. Add support for exemplars on constHistogram 

    Co-authored-by: William Perron <william.perron@shopify.com>
Signed-off-by: William Perron <william.perron@shopify.com>
    @arun-shopify @wperron
    arun-shopify and wperron committed Mar 7, 2022
    Copy the full SHA
    d7f6f6f View commit details
    Browse the repository at this point in the history

  2. remove GetExemplars function 

    Signed-off-by: William Perron <william.perron@shopify.com>
    @wperron
    wperron committed Mar 7, 2022
    Copy the full SHA
    3d744ce View commit details
    Browse the repository at this point in the history

  3. fixed linting warnings 

    reduce repetition in constHistogram w/ exemplar

Signed-off-by: William Perron <william.perron@shopify.com>
    @wperron
    wperron committed Mar 7, 2022
    Copy the full SHA
    ad6f1f6 View commit details
    Browse the repository at this point in the history

  4. Add values to correct bucket 

    Signed-off-by: William Perron <william.perron@shopify.com>
    @wperron
    wperron committed Mar 7, 2022
    Copy the full SHA
    47d3c54 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Misc fixes 

    Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>

Signed-off-by: William Perron <william.perron@shopify.com>
    @wperron
    wperron committed Mar 11, 2022
    Copy the full SHA
    16ac129 View commit details
    Browse the repository at this point in the history

  2. avoid panic when there are fewer buckets than exemplars 

    Co-authored-by: Arun Mahendra <arun.mahendra@shopify.com>

Signed-off-by: William Perron <william.perron@shopify.com>
    @arun-shopify @wperron
    arun-shopify authored and wperron committed Mar 11, 2022
    Copy the full SHA
    daaf45b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Added MustNewMetricWithExemplars that wraps metrics with exemplar (#3) 

    Changes:
* Make sure to not "leak" dto.Metric
* Reused upper bounds we already have for histogram
* Common code for all types.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    @bwplotka
    bwplotka committed Mar 16, 2022
    Copy the full SHA
    3c2e890 View commit details
    Browse the repository at this point in the history