smart diff to testutil.GatherAndCompare

go.mod

@@ -8,6 +8,7 @@ require (
 	github.com/prometheus/client_model v0.2.0
 	github.com/prometheus/common v0.32.1
 	github.com/prometheus/procfs v0.7.3
+	github.com/stretchr/testify v1.4.0
 	golang.org/x/sys v0.0.0-20220114195835-da31bd327af9
 	google.golang.org/protobuf v1.26.0
 )

prometheus/testutil/testutil.go

@@ -41,8 +41,10 @@ import (
 	"bytes"
 	"fmt"
 	"io"
+	"testing"
 
 	"github.com/prometheus/common/expfmt"
+	"github.com/stretchr/testify/require"
 
 	dto "github.com/prometheus/client_model/go"
 
@@ -154,27 +156,27 @@ func GatherAndCount(g prometheus.Gatherer, metricNames ...string) (int, error) {
 // CollectAndCompare registers the provided Collector with a newly created
 // pedantic Registry. It then calls GatherAndCompare with that Registry and with
 // the provided metricNames.
-func CollectAndCompare(c prometheus.Collector, expected io.Reader, metricNames ...string) error {
+func CollectAndCompare(t *testing.T, c prometheus.Collector, expected io.Reader, shouldFail bool, metricNames ...string) error {
 	reg := prometheus.NewPedanticRegistry()
 	if err := reg.Register(c); err != nil {
 		return fmt.Errorf("registering collector failed: %s", err)
 	}
-	return GatherAndCompare(reg, expected, metricNames...)
+	return GatherAndCompare(t, reg, expected, shouldFail, metricNames...)
 }
 
 // GatherAndCompare gathers all metrics from the provided Gatherer and compares
 // it to an expected output read from the provided Reader in the Prometheus text
 // exposition format. If any metricNames are provided, only metrics with those
 // names are compared.
-func GatherAndCompare(g prometheus.Gatherer, expected io.Reader, metricNames ...string) error {
-	return TransactionalGatherAndCompare(prometheus.ToTransactionalGatherer(g), expected, metricNames...)
+func GatherAndCompare(t *testing.T, g prometheus.Gatherer, expected io.Reader, shouldFail bool, metricNames ...string) error {
+	return TransactionalGatherAndCompare(t, prometheus.ToTransactionalGatherer(g), expected, shouldFail, metricNames...)
 }
 
 // TransactionalGatherAndCompare gathers all metrics from the provided Gatherer and compares
 // it to an expected output read from the provided Reader in the Prometheus text
 // exposition format. If any metricNames are provided, only metrics with those
 // names are compared.
-func TransactionalGatherAndCompare(g prometheus.TransactionalGatherer, expected io.Reader, metricNames ...string) error {
+func TransactionalGatherAndCompare(t *testing.T, g prometheus.TransactionalGatherer, expected io.Reader, shouldFail bool, metricNames ...string) error {
 	got, done, err := g.Gather()
 	defer done()
 	if err != nil {
@@ -190,14 +192,14 @@ func TransactionalGatherAndCompare(g prometheus.TransactionalGatherer, expected
 	}
 	want := internal.NormalizeMetricFamilies(wantRaw)
 
-	return compare(got, want)
+	return compare(t, got, want, shouldFail)
 }
 
 // compare encodes both provided slices of metric families into the text format,
 // compares their string message, and returns an error if they do not match.
 // The error contains the encoded text of both the desired and the actual
 // result.
-func compare(got, want []*dto.MetricFamily) error {
+func compare(t *testing.T, got, want []*dto.MetricFamily, shouldFail bool) error {
 	var gotBuf, wantBuf bytes.Buffer
 	enc := expfmt.NewEncoder(&gotBuf, expfmt.FmtText)
 	for _, mf := range got {
@@ -212,16 +214,17 @@ func compare(got, want []*dto.MetricFamily) error {
 		}
 	}
 
-	if wantBuf.String() != gotBuf.String() {
+	if shouldFail && wantBuf.String() != gotBuf.String() {
 		return fmt.Errorf(`
 metric output does not match expectation; want:
 
 %s
 got:
 
 %s`, wantBuf.String(), gotBuf.String())
-
 	}
+
+	require.Equal(t, wantBuf.String(), gotBuf.String())
 	return nil
 }
 

prometheus/testutil/testutil_test.go

@@ -18,6 +18,7 @@ import (
 	"testing"
 
 	"github.com/prometheus/client_golang/prometheus"
+	"github.com/stretchr/testify/require"
 )
 
 type untypedCollector struct{}
@@ -138,7 +139,7 @@ func TestCollectAndCompare(t *testing.T) {
 		some_total{ label1 = "value1" } 1
 	`
 
-	if err := CollectAndCompare(c, strings.NewReader(metadata+expected), "some_total"); err != nil {
+	if err := CollectAndCompare(t, c, strings.NewReader(metadata+expected), false, "some_total"); err != nil {
 		t.Errorf("unexpected collecting result:\n%s", err)
 	}
 }
@@ -160,7 +161,7 @@ func TestCollectAndCompareNoLabel(t *testing.T) {
 		some_total 1
 	`
 
-	if err := CollectAndCompare(c, strings.NewReader(metadata+expected), "some_total"); err != nil {
+	if err := CollectAndCompare(t, c, strings.NewReader(metadata+expected), false, "some_total"); err != nil {
 		t.Errorf("unexpected collecting result:\n%s", err)
 	}
 }
@@ -232,7 +233,7 @@ func TestCollectAndCompareHistogram(t *testing.T) {
 		}
 
 		t.Run(input.name, func(t *testing.T) {
-			if err := CollectAndCompare(input.c, strings.NewReader(input.metadata+input.expect)); err != nil {
+			if err := CollectAndCompare(t, input.c, strings.NewReader(input.metadata+input.expect), false); err != nil {
 				t.Errorf("unexpected collecting result:\n%s", err)
 			}
 		})
@@ -259,7 +260,7 @@ func TestNoMetricFilter(t *testing.T) {
 		some_total{label1="value1"} 1
 	`
 
-	if err := CollectAndCompare(c, strings.NewReader(metadata+expected)); err != nil {
+	if err := CollectAndCompare(t, c, strings.NewReader(metadata+expected), false); err != nil {
 		t.Errorf("unexpected collecting result:\n%s", err)
 	}
 }
@@ -297,14 +298,12 @@ got:
 some_total{label1="value1"} 1
 `
 
-	err := CollectAndCompare(c, strings.NewReader(metadata+expected))
+	err := CollectAndCompare(t, c, strings.NewReader(metadata+expected), true)
 	if err == nil {
 		t.Error("Expected error, got no error.")
 	}
 
-	if err.Error() != expectedError {
-		t.Errorf("Expected\n%#+v\nGot:\n%#+v", expectedError, err.Error())
-	}
+	require.EqualErrorf(t, err, expectedError, "Expected\n%#+v\nGot:\n%#+v", expectedError, err.Error())
 }
 
 func TestCollectAndCount(t *testing.T) {