Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more linters #473

Closed
wants to merge 1 commit into from
Closed

enable more linters #473

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

enable the follow linters

  • gocritic
  • gofumpt
  • goimports
  • gosimple
  • misspell
  • revive
  • unconvert
  • unused

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

@roidelapluie
Copy link
Member

We have conflicting files now. Does this reflect Prometheus/prometheus config?

@mmorel-35 mmorel-35 marked this pull request as draft May 12, 2023 16:03
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review May 13, 2023 08:17
@mmorel-35
Copy link
Contributor Author

We have conflicting files now.

I have dealt with it

Does this reflect Prometheus/prometheus config?

Yes, I tried to keep them as close as possible.

If you want to have the same accross all repositories, maybe creating a ".github" project could help ?

@mmorel-35 mmorel-35 closed this Jun 19, 2023
@mmorel-35 mmorel-35 deleted the linters branch June 19, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants