feat: add time template helpers #627
Open
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freak12techno
force-pushed
the
add-time-template-helpers
branch
3 times, most recently
from
a629df0
to
ca27390
Compare
|
@gotjosh can you look at this? |
beorn7
reviewed
May 8, 2024
freak12techno
force-pushed
the
add-time-template-helpers
branch
from
a6324bf
to
b0dc45a
Compare
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
Signed-off-by: Sergey <freak12techno@gmail.com>
freak12techno
force-pushed
the
add-time-template-helpers
branch
from
b0dc45a
to
270171b
Compare
|
Hi @freak12techno, in the old PR prometheus/alertmanager#3720 you also included time.since. Is it possible to add here? |
|
@LMantovan I'll still need to make a PR towards alertmanager to use this template, my plan is to add time.Since in the next PR which will supersede the one I closed. This one needs to be merged first regardless though. |
|
@gotjosh ping? |
|
@gotjosh are you up to reviewing this? Either way, could you comment so that we at least know you have seen this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from here https://github.com/prometheus/prometheus/blob/34ee8c607809cca973a1d7383713035045f681d8/template/template.go#L267, the eventual goal is to reuse it in Alertmanager as well to allow it as a template helper, and also in Prometheus.
Related: prometheus/alertmanager#3717
Related: prometheus/alertmanager#3720 (comment)
Function itself is moved as is, tests are updated as there's no templates rendering here.
Also
added theadded the go.mod entry to go.mod and go.sum (otherwise.ideato.gitignore(as I use Goland IDE and it creates some files that are probably not to be committed) andmake testwould fail).