Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hbase.yaml #459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hbase.yaml #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions example_configs/hbase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# The metrics look this this
# Hadoop<service=HBase, name=RegionServer, sub=Regions><>Namespace_foo_table_my_table_name_region_1234567xy_metric_scanNext_75th_percentile: 0.0
# So we have many many different metrics and it is hard to aggregate per namespace or per table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment, this is the usual way to do things.

# Idea is to have it under one metric and the details in the labels
# Idea came from https://blog.godatadriven.com/hbase-prometheus-monitoring
rules:
- pattern: Hadoop<service=HBase, name=RegionServer, sub=Regions><>Namespace_(.+)_table_(.+)_region_(.+)_metric_(.+):\ (.+)
name: HBase_metric_$4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metric is redundant here

we also go with lowercase, so hbase

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be added so that it does not overwrite other metrics which may overlap or have different type.

for example in HBase you can have already generated metric named Hbase_active: 1.0

Then there is some hbase data with below structure (abbreviated)
...Namespace_test_table_meta_region_abc_metric_get: 20
and which would produce Hbase_active with labels namespace=test,table=meta,region=abc with value 20.0

In that case it would cause metric clash.

I would keep lowercase, as suggested.

labels:
namespace: "$1"
table: "$2"
region: "$3"
value: "$5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you not leaving this to the default?