Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging level to SEVERE for Exception #604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaipan
Copy link

@shaipan shaipan commented May 7, 2021

Currently, all exceptions are logged as FINE level. The FINE level gives too much log. We should be having SEVERE level for Exceptions.

Currently, all exceptions are logged as FINE level. The FINE level gives too much log. We should be having SEVERE level for Exceptions.
@fstab
Copy link
Member

fstab commented May 15, 2021

Thanks for the PR. Did you get these exceptions in a real world scenario? If so, it would be interesting to hear what happened. I'd like to avoid spamming user's log files with SEVERE messages, and it's hard to decide what is severe without an actual example.

@shaipan
Copy link
Author

shaipan commented May 16, 2021

Thanks for the PR. Did you get these exceptions in a real world scenario? If so, it would be interesting to hear what happened. I'd like to avoid spamming user's log files with SEVERE messages, and it's hard to decide what is severe without an actual example.

We are setting an VM option -Dsun.rmi.transport.tcp.responseTimeout=30000. And our scrapping interval is 25s. So if some bean is taking more time to scrap than the scrapping interval, we wanted to capture it in the logs so that the problem bean can be identified. But due to FINE logging, the logs generated are too much and we cant keep all the logs in the production environment. So wanted to keep only SEVERE logs. On seeing java.net.SocketTimeoutException we can know that this particular bean took more time than 30s.

@dhoard
Copy link
Collaborator

dhoard commented Dec 22, 2021

@shaipan what is the status of the PR? Can you resolve the changes as well as complete the checks (DCO)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants