Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector/zfs: Prevent procfs integer underflow #2961

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rexagod
Copy link
Contributor

@rexagod rexagod commented Mar 18, 2024

Prevent integer underflow when parsing the procfs file as it used a ParseUint to parse signed values.

Fixes: #2766

@rexagod rexagod marked this pull request as draft March 18, 2024 22:16
@rexagod rexagod force-pushed the 2766 branch 3 times, most recently from daa4dc2 to e1b26a9 Compare March 18, 2024 22:53
@rexagod rexagod marked this pull request as ready for review March 18, 2024 23:01
@rexagod rexagod force-pushed the 2766 branch 6 times, most recently from dd7ee81 to f969e6a Compare March 18, 2024 23:55
Prevent integer underflow when parsing the `procfs` file as it used a
`ParseUint` to parse signed values.

Fixes: prometheus#2766
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
collector/zfs.go Outdated Show resolved Hide resolved
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Contributor Author

rexagod commented May 12, 2024

Bump.

@discordianfish
Copy link
Member

@SuperQ ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional ZFS collector errors on kstat.zfs.misc.arcstats.memory_available_bytes
3 participants