-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
udp_queues_linux.go: Expose UDP drops via gauge analogous to queue sizes #2993
base: master
Are you sure you want to change the base?
Conversation
084bd27
to
b297b22
Compare
@discordianfish @SuperQ I'm assuming that the failing circleci tests are because I need to update the fixtures (via |
Ensure identical build flags embedded in both files. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
…zes. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
b297b22
to
271bcee
Compare
Update e2e test output to include the drops. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
I'm not sure why |
Don't use a pointer without checking it first. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, no, this seems incorrect. Drops appears to be a counter, so this needs to be a new metric, not a label on an existing metric.
Drat; you're right. Let me see if I can fix this quickly. |
I think it makes sense for "drops" to sit alongside the queue length gauges in prom stats because they are all neighbors in procfs (source of these stats). Moreover, in reading the commit log message for the original creating work for udp_queues, I think there may have been some misreading or confusion between the word "state" and the common short-form of "stats" to mean "statistics". The original author "chose the name 'udp_queue' instead of 'udpstat' as UDP has no state"; I believe that 'udpstat' might actually be the more appropriate name. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
Since a common reason for monitoring UDP queue sizes can be in teasing out performance and QoS issues, it would be convenient to have drops available in the same frames of data. Since the underlying source of the data provides that information, this PR exposes drops modeled as a gauge just as queue sizes are.
@discordianfish @SuperQ