add avgRTT to nfs mountstats #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO sign-off missing but LGTM otherwise |
ksankeerth
force-pushed
the
mountstats_nfs_avg_rtt
branch
2 times, most recently
from
6560fcf
to
424aab3
Compare
Signed-off-by: shankeerthan-kasilingam <shankeerthan1995@gmail.com>
ksankeerth
force-pushed
the
mountstats_nfs_avg_rtt
branch
from
424aab3
to
49163ee
Compare
Thanks for reviewing again. Fixed the DCO issue and renamed |
discordianfish
approved these changes
Mar 21, 2023
|
Hi @SuperQ, Could you please review this PR when you have time? Thanks in advance! |
SuperQ
approved these changes
May 5, 2023
|
I just realized that this feature is not something we should have in the code. It's computing an artificial value from existing data, which is not something we do in our libraries. If you want to compute this value, you can do it upstream. |
SuperQ
added a commit
that referenced
this pull request
Mar 28, 2024
This is an artificiality computed value from existing values. The goal of this library is to provide simple raw access to values, rather than pre-compute data. Reverts: #487 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I'm sending this PR to add avgRTT to nfs mount stats. prometheus/node_exporter#2550
I followed the same approach as linux kernel to calculate
avgRTT. https://git.linux-nfs.org/?p=bfields/nfs-utils.git;a=blob;f=tools/nfs-iostat/nfs-iostat.py;h=1df74ba822b59f68c556530e6bf825a1e57f611d;hb=HEAD#l342Let me know your feedback.
cc : @discordianfish
Thanks!