Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add avgRTT to nfs mountstats #487

Merged
merged 1 commit into from
May 5, 2023
Merged

add avgRTT to nfs mountstats #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion mountstats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ type NFSOperationStats struct {
CumulativeTotalResponseMilliseconds uint64
// Duration from when a request was enqueued to when it was completely handled.
CumulativeTotalRequestMilliseconds uint64
// The average time from the point the client sends RPC requests until it receives the response.
AverageRTTMilliseconds float64
// The count of operations that complete with tk_status < 0. These statuses usually indicate error conditions.
Errors uint64
}
Expand Down Expand Up @@ -534,7 +536,6 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {

ns = append(ns, n)
}

opStats := NFSOperationStats{
Operation: strings.TrimSuffix(ss[0], ":"),
Requests: ns[0],
Expand All @@ -546,6 +547,9 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {
CumulativeTotalResponseMilliseconds: ns[6],
CumulativeTotalRequestMilliseconds: ns[7],
}
if ns[0] != 0 {
discordianfish marked this conversation as resolved.
Show resolved Hide resolved
opStats.AverageRTTMilliseconds = float64(ns[6]) / float64(ns[0])
}

if len(ns) > 8 {
opStats.Errors = ns[8]
Expand Down
2 changes: 2 additions & 0 deletions mountstats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 6,
CumulativeTotalResponseMilliseconds: 79386,
CumulativeTotalRequestMilliseconds: 79407,
AverageRTTMilliseconds: 61.16024653312789,
},
{
Operation: "WRITE",
Expand All @@ -352,6 +353,7 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 18446743919241604546,
CumulativeTotalResponseMilliseconds: 1667369447,
CumulativeTotalRequestMilliseconds: 1953587717,
AverageRTTMilliseconds: 0.5695744656983355,
},
},
Transport: NFSTransportStats{
Expand Down