nomad service discovery: add support for filtering by service or tag #14108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaloren
force-pushed
the
feature/nomad-sd-tags
branch
4 times, most recently
from
cc8b0fc
to
ca05268
Compare
Fixes prometheus#11775 Signed-off-by: Joseph Lorenzini <jaloren@fastmail.com>
jaloren
force-pushed
the
feature/nomad-sd-tags
branch
from
ca05268
to
8a9c21b
Compare
|
@roidelapluie As i was looking through the nomad api, I realized that its not exposing allocation id. This is useful for identifying anomalies that are occurring on specific instances of a service. In this PR, I propose we include allocation id as a new tag. On other hand, this could turn into a high cardinality label so this might be a foot gun. And on third hand i suppose node id and service id might be good enough. Unsure. Thoughts? https://github.com/hashicorp/nomad/blob/main/api/services.go#L46 |
|
@roidelapluie just wanted to touch base and see if there's anything more that is needed from me to get this PR merged. If there isn't and this will get merged when time permits, then I'll put a pin on this and check back in a few weeks. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11775