Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Bits as OctetString #870

Merged
merged 1 commit into from
May 2, 2023
Merged

Treat Bits as OctetString #870

merged 1 commit into from
May 2, 2023

Conversation

sebastien-coavoux
Copy link
Contributor

Related to #855 , looks like this quick fix is the best option until we have a use case to elaborate more

@sebastien-coavoux
Treat Bits as OctetString
04f5c0a 
Signed-off-by: Sébastien Coavoux <sebastien.coavoux@azoplee.com>
@sebastien-coavoux
Copy link
Contributor Author

poke @SuperQ in case you missed it

SuperQ
SuperQ approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 9999e59 into prometheus:main May 2, 2023
2 checks passed
SuperQ added a commit that referenced this pull request Jun 15, 2023
@SuperQ
Release v0.22.0
b365b8d 
* [FEATURE] Add indices filters #624
* [FEATURE] Add MIBOPTS flag to the generator 891
* [ENHANCEMENT] Treat Bits as OctetString #870
* [ENHANCEMENT] Report duration in logs for canceled scrapes #876

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jun 15, 2023
Merged
SuperQ added a commit that referenced this pull request Jun 15, 2023
@SuperQ
Release v0.22.0
8541efc 
* [FEATURE] Add indices filters #624
* [FEATURE] Add MIBOPTS flag to the generator #891
* [ENHANCEMENT] Treat Bits as OctetString #870
* [ENHANCEMENT] Report duration in logs for canceled scrapes #876
* [BUGFIX] Fix several generator MIBs. #843, #868, #889

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jun 15, 2023
@SuperQ
Release v0.22.0 (#896)
7b0657f 
* [FEATURE] Add indices filters #624
* [FEATURE] Add MIBOPTS flag to the generator #891
* [ENHANCEMENT] Treat Bits as OctetString #870
* [ENHANCEMENT] Report duration in logs for canceled scrapes #876
* [BUGFIX] Fix several generator MIBs. #843, #868, #889

Signed-off-by: SuperQ <superq@gmail.com>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@sebastien-coavoux
Treat Bits as OctetString (prometheus#870)
5a181b7 
Signed-off-by: Sébastien Coavoux <sebastien.coavoux@azoplee.com>
Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release v0.22.0 (prometheus#896)
2f1332a 
* [FEATURE] Add indices filters prometheus#624
* [FEATURE] Add MIBOPTS flag to the generator prometheus#891
* [ENHANCEMENT] Treat Bits as OctetString prometheus#870
* [ENHANCEMENT] Report duration in logs for canceled scrapes prometheus#876
* [BUGFIX] Fix several generator MIBs. prometheus#843, prometheus#868, prometheus#889

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebastien-coavoux @SuperQ