Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profile): sortable links #1392

Merged
merged 13 commits into from Jan 14, 2023
Merged

chore(profile): sortable links #1392

merged 13 commits into from Jan 14, 2023

Conversation

poolsar42
Copy link
Collaborator

Description

Makes links sortable to be able to change their order for /$profile

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation website
  • I have made corresponding changes to the literal docs
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@poolsar42 poolsar42 self-assigned this Jan 12, 2023
@poolsar42
Copy link
Collaborator Author

@poolsar42 poolsar42 force-pushed the feat/profile-links-order branch 2 times, most recently from 3f8d8cb to ac540dc Compare January 13, 2023 00:15
@poolsar42 poolsar42 marked this pull request as ready for review January 13, 2023 16:16
@poolsar42
Copy link
Collaborator Author

poolsar42 commented Jan 13, 2023

make it after generic component is landed:

  • change view of "add link" button as in figma
  • fix z-index and make inner shadow outer shadow
  • fix tooltip font and tooltip colors in desing systems
  • doesn't show automatically empty input component for link. only when "add link" is clicked
  • add pop-up component when users tries to go away with unsaved changes
  • fix the bug when links are empty in /account loader

@poolsar42
Copy link
Collaborator Author

poolsar42 commented Jan 14, 2023

make it after generic component is landed:

  • change view of "add link" button as in figma
  • fix z-index and make inner shadow outer shadow
  • fix tooltip font and tooltip colors in desing systems
  • doesn't show automatically empty input component for link. only when "add link" is clicked
  • add pop-up component when users tries to go away with unsaved changes
  • fix the bug when links are empty in /account loader
  • for unsaved changed modal component is created, but to block redirect we need to use feature that from this issue. it is only in prerelease now, probably will need to update react-router-dom
  • z-index doesn't help for positioning dragged links. not sure how to make it, open to any suggestions
  • changing this tooltip font doesn't seem to be possible. probably need to re-implement this component other way cc: @Cosmin-Parvulescu (probably this can be helpful)

@maurerbot maurerbot merged commit c62be7a into main Jan 14, 2023
@maurerbot maurerbot deleted the feat/profile-links-order branch January 14, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(profile): make links draggable and save order
2 participants