Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StopWatch in seconds + VNodeState string backed enum #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grymmare
Copy link

@grymmare grymmare commented Oct 2, 2023

  1. Connecting to a cluster does not work, the node state returned from the server is a string, so either we need VNodeState to be a string backed enum (as suggested in this PR) or a custom factory needs to be created, if keeping the integers is important.

  2. In the new amp v3 version, timeouts/intervals in the connection settings are configured in seconds (floats) rather than milliseconds. This PR changes the stopwatch to return a float (in seconds) instead of an int (in milliseconds)

@prolic
Copy link
Member

prolic commented Feb 13, 2024

Sorry for my late reply. What's the reason for the changes on VNodeState? I don't get it.

@grymmare
Copy link
Author

MemberInfoDto does VNodeState::from($value), where $value is a string. MemberInfoDto is created by ClusterDnsEndPointDiscoverer::tryGetGossipFrom(). Without the backed enum it failed to construct.

I'm using eventstore 23.10, but I believe at the time I was at 22.10.

@prolic
Copy link
Member

prolic commented Feb 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants