Fix for #1021 and preparation for #1012 #1022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 11, 2015 13:53
Especially the doc blocks should now be much better than before.
Especially doc blocks should be much cleaner.
This reverts commit c0c8ed0.
…urn value type integer.
Added `$comparison` as second argument to the `filterByPrimaryKey` methods of the generated query classes.
| @@ -670,7 +670,7 @@ protected function addFilterByPrimaryKey(&$script) | |||
| * | |||
| * @return " . $this->getStubQueryBuilder()->getClassname() . " The current query, for fluid interface | |||
| */ | |||
| public function filterByPrimaryKey(\$key) | |||
| public function filterByPrimaryKey(\$key, \$comparison = Criteria::EQUAL) | |||
| {"; | |||
There was a problem hiding this comment.
Nice patch ;)
Just a minor suggestion:
add the new "@param string $comparison" in the description of this method ;)
|
You are absolutely right. Thanks. |
|
+1, but please squash the changes :) |
| @@ -1,3 +1,51 @@ | |||
| ### JetBrains template | |||
There was a problem hiding this comment.
This should be removed from the projects .gitignore.
It should be part of your user specific gitignore (usually at ~/.gitignore configured via core.excludesfile).
There was a problem hiding this comment.
Jepp. You are right. My very own .gitignore should have not benn part of the commit.
|
Well, thanks, but v1 is freezed. We're not going to release any new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains unanswered PR propelorm/Propel#1011changes also.