[WIP] Fixed issues related to MSSQL #1431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSSQL - Uncaught 'PDOException' - "attribute only supported on PDOStatement object"
propelorm#1294 propelorm#1343 Solved: - size checking issue - default values issue - foreign keys actions (on delete/on update) Remaining: - sql syntax for alter table
propelorm#1294 propelorm#1343 Solved: - column renaming
propelorm#1294 propelorm#1343 Solved: - column changing (structure)
- alter multiple columns - create/drop (unique) indexes
MSSQL - Uncaught 'PDOException' - "attribute only supported on PDOStatement object"
propelorm#1294 propelorm#1343 Solved: - size checking issue - default values issue - foreign keys actions (on delete/on update) Remaining: - sql syntax for alter table
propelorm#1294 propelorm#1343 Solved: - column renaming
propelorm#1294 propelorm#1343 Solved: - column changing (structure)
- alter multiple columns - create/drop (unique) indexes
prgTW
reviewed
Nov 22, 2017
| @@ -786,7 +786,7 @@ public function setupReferrers($throwErrors = false) | |||
|
|
|||
| // check for incomplete foreign key references when foreign table | |||
| // has a composite primary key | |||
| if ($foreignTable->hasCompositePrimaryKey()) { | |||
| if (!is_null($foreignTable) && $foreignTable->hasCompositePrimaryKey()) { | |||
There was a problem hiding this comment.
👍 as it fixes this specific case
atompulse
changed the title
|
Can you rebase on top of latest master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on a project using MSSQL so I was forced to tackle these issues:
#1294
#1343