Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.2 compatibility : Partially-supported callable are deprecated #1979

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romaincousseau
Copy link

The propel gen command when a table in schema.xml depends on a baseClass generates code
in the "Base" namespace that is not compatible with PHP 8.2.

For example, when saving the object, a deprecation warning is displayed:
Deprecated: Use of "self" in callables is deprecated in ... on line ...

This is a known issue whith PHP8.2 :
https://php.watch/versions/8.2/partially-supported-callable-deprecation

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fd10bf) 89.28% compared to head (c6b4add) 89.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1979   +/-   ##
=========================================
  Coverage     89.28%   89.28%           
  Complexity     8058     8058           
=========================================
  Files           232      232           
  Lines         24534    24534           
=========================================
  Hits          21905    21905           
  Misses         2629     2629           
Flag Coverage Δ
5-max 89.28% <ø> (ø)
7.4 89.28% <ø> (ø)
agnostic 67.44% <ø> (ø)
mysql 69.83% <ø> (ø)
pgsql 69.87% <ø> (ø)
sqlite 67.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants