Option to disable KeyValuePairSerializer #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
approved these changes
Mar 19, 2021
|
@mgravell Is there anything left for me to do here (add to release notes/change docs, some extra documentation somewhere?) or will this be included in the next release when there are enough issues to warrant you spending your spare time to create one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #701 there's currently some rather unexpected behavior where tuple-like types can be serialized/deserialized by protobuf-net even without being annotated if they follow certain conventions.
This PR introduces a new flag
AllowImplicitTuples(the naming could surely be improved) to disable this behavior. By default the behavior is not changed.