Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support open generic metatypes #857

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/protobuf-net.Test/Meta/OpenGenericMetaType.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
using ProtoBuf.Meta;
using Xunit;

namespace ProtoBuf.Test.Meta
{
public class OpenGenericMetaTypeTests
{
public class OpenGenericTarget<T>
{
public T Value { get; set; }
}

[ProtoContract]
public class OpenGenericSurrogate<T>
{
[ProtoMember(1)]
public T Value { get; set; }


public static implicit operator OpenGenericTarget<T>(OpenGenericSurrogate<T> surrogate)
{
return surrogate == null ? null : new OpenGenericTarget<T>
{
Value = surrogate.Value
};
}

public static implicit operator OpenGenericSurrogate<T>(OpenGenericTarget<T> source)
{
return source == null ? null : new OpenGenericSurrogate<T>
{
Value = source.Value
};
}
}

[Fact]
public void OpenGenericMetaTypeSerialization()
{
RuntimeTypeModel.Default.Add(typeof(OpenGenericTarget<>)).SetSurrogate(typeof(OpenGenericSurrogate<>));

var instance = new OpenGenericTarget<string> { Value = "XYZ!" };
var clone = RuntimeTypeModel.Default.DeepClone(instance);

Assert.Equal(instance.Value, clone.Value);
}
}
}
11 changes: 11 additions & 0 deletions src/protobuf-net/Meta/MetaType.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2482,5 +2482,16 @@ static string CommentSuffix(ProtoReservedAttribute reservation)
return " (" + comment.Trim() + ")";
}
}

internal MetaType GenerateGenericType(Type type)
{
var metaType = new MetaType(model, type, factory);
metaType.SetSurrogate(surrogateType.GetGenericTypeDefinition());
metaType._compatibilityLevel = _compatibilityLevel;
metaType._fields = _fields;
metaType._enums = _enums;
metaType._reservations = _reservations;
return metaType;
}
}
}
31 changes: 25 additions & 6 deletions src/protobuf-net/Meta/RuntimeTypeModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -719,15 +719,34 @@ internal int FindOrAddAuto(Type type, bool demand, bool addWithContractOnly, boo
shouldAdd = addEvenIfAutoDisabled = true; // always add basic tuples, such as KeyValuePair
}

if (!shouldAdd || (
!type.IsEnum && addWithContractOnly && family == MetaType.AttributeFamily.None)
)
// for generic types, when no contract is set, see if a generic definition is registered and use that
if (type.IsGenericType && !type.IsGenericTypeDefinition && family == MetaType.AttributeFamily.None)
{
if (demand) ThrowUnexpectedType(type, this);
return key;
var genericTypeDefinition = type.GetGenericTypeDefinition();
key = types.IndexOf(MetaTypeFinder, genericTypeDefinition);
if (key >= 0)
{
var genericMetaType = (MetaType)types[key];
if (genericMetaType.Pending)
{
WaitOnLock();
}
Comment on lines +729 to +733
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda winging this part here based on existing code further up in the method.

metaType = genericMetaType.GenerateGenericType(type);
}
}

metaType = Create(type);
if (metaType is null)
{
Comment on lines +738 to +739
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional check seemed like the best solution to avoid triggering the next block if a metatype was generated in the new code I wrote. In my head it was either this or a goto statement.

if (!shouldAdd || (
!type.IsEnum && addWithContractOnly && family == MetaType.AttributeFamily.None)
)
{
if (demand) ThrowUnexpectedType(type, this);
return key;
}

metaType = Create(type);
}
}

metaType.Pending = true;
Expand Down