proto: fix HasPresence for extensions and missing plugin response

Change-Id: I9ee81f7a88cf91f3041e89936cb03511bd224603 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/574375 Auto-Submit: Lasse Folger <lassefolger@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Stapelberg <stapelberg@google.com>
protocolbuffers · Mar 26, 2024 · 3ebf7dd · 3ebf7dd
1 parent dea00b5
commit 3ebf7dd
Show file tree

Hide file tree

Showing 5 changed files with 732 additions and 399 deletions.
diff --git a/cmd/protoc-gen-go/main.go b/cmd/protoc-gen-go/main.go
@@ -51,6 +51,8 @@ func main() {
 			}
 		}
 		gen.SupportedFeatures = gengo.SupportedFeatures
+		gen.SupportedEditionsMinimum = gengo.SupportedEditionsMinimum
+		gen.SupportedEditionsMaximum = gengo.SupportedEditionsMaximum
 		return nil
 	})
 }
diff --git a/internal/filedesc/desc.go b/internal/filedesc/desc.go
@@ -333,7 +333,7 @@ func (fd *Field) HasPresence() bool {
 	if fd.L1.Cardinality == protoreflect.Repeated {
 		return false
 	}
-	return fd.L1.EditionFeatures.IsFieldPresence || fd.L1.Message != nil || fd.L1.ContainingOneof != nil
+	return fd.IsExtension() || fd.L1.EditionFeatures.IsFieldPresence || fd.L1.Message != nil || fd.L1.ContainingOneof != nil
 }
 func (fd *Field) HasOptionalKeyword() bool {
 	return (fd.L0.ParentFile.L1.Syntax == protoreflect.Proto2 && fd.L1.Cardinality == protoreflect.Optional && fd.L1.ContainingOneof == nil) || fd.L1.IsProto3Optional