-
Notifications
You must be signed in to change notification settings - Fork 379
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
all: update to protobuf 27.0-rc1 and regenerate protos
This change required some changes to the editions default handling code because the descriptor.proto changed upstream [2]. The defaults are no longer one feature set but are split into overridable and not-overridable features which have to be merged. I had to do bootstraping in 4 phases but the results should be correct: 1. generate everything depending on descriptor.proto 2. generate new defaults binary proto 3. adjust all code that works with defaults (*/edition.go files) 4. generate everything else The was required because 1. is a prerequisite for 3. while 2. and 3. are a prerequisite for 4. (2. and 3. can probably be done in parallel). The new release also introduced new conformance tests. The go implementation is not yet conformant and the tests will be fixed in a follow up change because they require changes to the protojson and protoext encoders. [1] protocolbuffers/protobuf@e5502c7 Change-Id: Iddf248f6582a0402ab31256f6e64755d870ed82c Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/582635 Auto-Submit: Lasse Folger <lassefolger@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicolas Hillegeer <aktau@google.com>
- Loading branch information
Showing
17 changed files
with
4,398 additions
and
1,696 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.