Merge pull request #8364 from haberman/ruby-memory-footprint

[Ruby] Fixed quadratic memory usage when appending to arrays.
protocolbuffers · Mar 2, 2021 · 069f989 · 069f989
2 parents 85e5204 + 88243e4
commit 069f989
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/ruby/ext/google/protobuf_c/ruby-upb.c b/ruby/ext/google/protobuf_c/ruby-upb.c
@@ -6663,10 +6663,9 @@ void upb_array_set(upb_array *arr, size_t i, upb_msgval val) {
 }
 
 bool upb_array_append(upb_array *arr, upb_msgval val, upb_arena *arena) {
-  if (!_upb_array_realloc(arr, arr->len + 1, arena)) {
+  if (!upb_array_resize(arr, arr->len + 1, arena)) {
     return false;
   }
-  arr->len++;
   upb_array_set(arr, arr->len - 1, val);
   return true;
 }