Add binary conformance test for enum fields. (#6434)

* Add binary conformance test for enum fields. * Add failed conformance test to js failure list
protocolbuffers · Jul 23, 2019 · 455440f · 455440f
1 parent 2c76c2c
commit 455440f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/conformance/binary_json_conformance_suite.cc b/conformance/binary_json_conformance_suite.cc
@@ -804,11 +804,16 @@ void BinaryAndJsonConformanceSuite::RunSuiteImpl() {
     {delim("\xfb"), "\"\xfb\""},
     {delim(""), "\"\""},
   });
+  TestValidDataForType(FieldDescriptor::TYPE_ENUM, {
+    {varint(0), "FOO"},
+    {varint(1), "BAR"},
+    {varint(2), "BAZ"},
+    {varint(-1), "NEG"},
+  });
 
   // TODO(haberman):
   // TestValidDataForType(FieldDescriptor::TYPE_GROUP
   // TestValidDataForType(FieldDescriptor::TYPE_MESSAGE
-  // TestValidDataForType(FieldDescriptor::TYPE_ENUM
 
   RunValidJsonTest("HelloWorld", REQUIRED,
                    "{\"optionalString\":\"Hello, World!\"}",

diff --git a/conformance/failure_list_js.txt b/conformance/failure_list_js.txt
@@ -11,3 +11,4 @@ Required.Proto3.ProtobufInput.ValidDataRepeated.SINT32.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.SINT64.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.UINT32.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.UINT64.ProtobufOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.ENUM.ProtobufOutput