add error returns missing from protoc to prevent it from exiting with…

… a successful return value when writing the zip file fails
protocolbuffers · Mar 17, 2021 · 57e09ad · 57e09ad
1 parent 4c5465e
commit 57e09ad
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/google/protobuf/compiler/command_line_interface.cc b/src/google/protobuf/compiler/command_line_interface.cc
@@ -586,10 +586,12 @@ bool CommandLineInterface::GeneratorContextImpl::WriteAllToZip(
 
   if (stream.GetErrno() != 0) {
     std::cerr << filename << ": " << strerror(stream.GetErrno()) << std::endl;
+    return false;
   }
 
   if (!stream.Close()) {
     std::cerr << filename << ": " << strerror(stream.GetErrno()) << std::endl;
+    return false;
   }
 
   return true;