Skip to content

Commit

Permalink
Roll forward Ruby upb changes now that protobuf Ruby build is fixed (#…
Browse files Browse the repository at this point in the history
…5866)

* Rolled forward again with "Updated upb from defcleanup branch..."

Revert "Revert "Updated upb from defcleanup branch and modified Ruby to use it (#5539)" (#5848)"

This reverts commit 1568dea.

* A few more merge fixes.

* Updated for defcleanup2 branch.

* Fixed upb to define upb_decode().

* Fixed names of nested messages.

* Revert submodule.

* Set -std=gnu90 and fixed warnings/errors.

Some of our Kokoro tests seem to run with this level of warnings,
and the source strives to be gnu90 compatible.  Enforcing it for
every build removes the possibility of some errors showing up in
Kokoro/Travis tests only.

* Fixed remaining warnings with gnu90 mode.

I tried to match warning flags with what Ruby appears to do
in our Kokoro tests.

* Initialize values registered by rb_gc_register_address().

* Fixed subtle GC bug.

We need to initialize this marked value before creating the instance.

* Truly fix the GC bug.

* Updated upb for mktime() fix.

* Removed XOPEN_SOURCE as we are not using strptime().

* Removed fixed tests from the conformance failure list for Ruby.

* Fixed memory error related to oneof def names.

* Picked up new upb changes re: JSON printing.

* Uncomment concurrent decoding test.
  • Loading branch information
haberman authored and TeBoring committed Aug 14, 2019
1 parent 402c28a commit 63f324a
Show file tree
Hide file tree
Showing 16 changed files with 10,752 additions and 18,426 deletions.
3 changes: 0 additions & 3 deletions ruby/compatibility_tests/v3.0.0/tests/basic.rb
Expand Up @@ -67,7 +67,6 @@ module BasicTest
add_message "BadFieldNames" do
optional :dup, :int32, 1
optional :class, :int32, 2
optional :"a.b", :int32, 3
end

add_message "MapMessage" do
Expand Down Expand Up @@ -1067,8 +1066,6 @@ def test_bad_field_names
assert m['class'] == 2
m['dup'] = 3
assert m['dup'] == 3
m['a.b'] = 4
assert m['a.b'] == 4
end

def test_int_ranges
Expand Down

0 comments on commit 63f324a

Please sign in to comment.