Merge pull request #8005 from haberman/php-filefix

Moved HasOneof test into GeneratedClassTest.php, to avoid the extra file.
protocolbuffers · Nov 4, 2020 · 7b56ea3 · 7b56ea3
2 parents 957a0bf + a8a1493
commit 7b56ea3
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 28 deletions.
diff --git a/php/phpunit.xml b/php/phpunit.xml
@@ -13,7 +13,6 @@
       <file>tests/DescriptorsTest.php</file>
       <file>tests/GeneratedServiceTest.php</file>
       <file>tests/WrapperTypeSettersTest.php</file>
-      <file>tests/HasOneofTest.php</file>
     </testsuite>
   </testsuites>
 </phpunit>
diff --git a/php/tests/GeneratedClassTest.php b/php/tests/GeneratedClassTest.php
@@ -1671,6 +1671,23 @@ public function testDeepEquality()
         # TODO: what about unknown fields?
     }
 
+    #########################################################
+    # Test hasOneof<Field> methods exists and working
+    #########################################################
+
+    public function testHasOneof() {
+        $m = new TestMessage();
+        $this->assertFalse($m->hasOneofInt32());
+        $m->setOneofInt32(42);
+        $this->assertTrue($m->hasOneofInt32());
+        $m->setOneofString("bar");
+        $this->assertFalse($m->hasOneofInt32());
+        $this->assertTrue($m->hasOneofString());
+        $m->clear();
+        $this->assertFalse($m->hasOneofInt32());
+        $this->assertFalse($m->hasOneofString());
+    }
+
     #########################################################
     # Test no segfault when error happens
     #########################################################

diff --git a/php/tests/HasOneofTest.php b/php/tests/HasOneofTest.php
diff --git a/php/tests/test.sh b/php/tests/test.sh
@@ -29,7 +29,7 @@ esac
 
 [ -f $PHPUNIT ] || wget https://phar.phpunit.de/$PHPUNIT
 
-tests=( ArrayTest.php EncodeDecodeTest.php GeneratedClassTest.php MapFieldTest.php WellKnownTest.php DescriptorsTest.php WrapperTypeSettersTest.php HasOneofTest.php)
+tests=( ArrayTest.php EncodeDecodeTest.php GeneratedClassTest.php MapFieldTest.php WellKnownTest.php DescriptorsTest.php WrapperTypeSettersTest.php)
 
 for t in "${tests[@]}"
 do