Skip to content

Commit

Permalink
Merge pull request #6202 from haon4/update_contributing
Browse files Browse the repository at this point in the history
Update CONTRIBUTING.md to clarify who should set the labels
  • Loading branch information
Hao Nguyen committed May 31, 2019
2 parents 74f4f59 + e06c5ff commit ca7ae52
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ the final release.
Ultimately, the green signal will be provided by our testing infrastructure.
The reviewer will help you if there are test failures that seem not related
to the change you are making.

## Reviewer Guidelines

* Make sure that all tests are passing before approval.
* Apply the "release notes: yes" label if the pull request's description should
be included in the next release (e.g., any new feature / bug fix).
Apply the "release notes: no" label if the pull request's description should
Expand All @@ -92,4 +96,3 @@ the final release.
pull request. This will make it easier to identify which languages the pull
request affects, allowing us to better identify appropriate reviewer, create
a better release note, and make it easier to identify issues in the future.

0 comments on commit ca7ae52

Please sign in to comment.