Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ObjC] Add support for using the proto package to prefix symbols.
This likely should have been the default from the start, as without it is way to common to get symbol collisions between different proto files. It would be nice to support a "migration" mode where both names are created to aid it moving code to this model, but with ObjC `@class` decls being very common to avoid header imports to control rebuilds/etc., it doesn't work as an `@class` usage will error if one also uses `@compatibility_alias`. Falling back to `#define` the two together also doesn't work as the header with the `@class` will cause methods to get defined with one interface, but when methods taking those types are define will likely #import the generate header and thus get the define and end up with a different signature. So for now, there is no migration support and code has to be updated in one shot with enable the new prefixing. - Add a generation option to enable this change in generation. - Add a second generation option to provide a list of proto package that are exceptions from using the proto package. This allows easier migration/updating of code one package at a time.
- Loading branch information
Showing
5 changed files
with
234 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters