fix ubsan warning

Signed-off-by: Asra Ali <asraa@google.com>
protocolbuffers · Jul 3, 2019 · de3e728 · de3e728
1 parent 8b09686
commit de3e728
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/google/protobuf/stubs/strutil.cc b/src/google/protobuf/stubs/strutil.cc
@@ -1065,10 +1065,12 @@ char* FastUInt32ToBufferLeft(uint32 u, char* buffer) {
 }
 
 char* FastInt32ToBufferLeft(int32 i, char* buffer) {
-  uint32 u = i;
+  uint32 u = 0;
   if (i < 0) {
     *buffer++ = '-';
-    u = -i;
+    u -= i;
+  } else {
+    u = i;
   }
   return FastUInt32ToBufferLeft(u, buffer);
 }