[Ruby] Fixed quadratic memory usage when appending to arrays. #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code mistakenly called realloc() instead of resize() on every array append, causing quadratic memory usage.
acozzette
approved these changes
Mar 2, 2021
|
@haberman @acozzette I don't think this made it into 3.15.4 AFAICT and it's mistakenly in the release notes there. https://github.com/protocolbuffers/protobuf/blob/v3.15.4/ruby/ext/google/protobuf_c/ruby-upb.c#L6666 |
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code mistakenly called realloc() instead of resize() on every
array append, causing quadratic memory usage.
This fixes the problem reported in #8337 (comment)