Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python aarch64 linux tests broken by recent piper import #8667

Closed
jtattermusch opened this issue May 27, 2021 · 1 comment · Fixed by #8746
Closed

Python aarch64 linux tests broken by recent piper import #8667

jtattermusch opened this issue May 27, 2021 · 1 comment · Fixed by #8746
Assignees
Labels

Comments

@jtattermusch
Copy link
Contributor

After this diff: 998d3a3...636132b from
#8617

the linux/python_aarch64 test got broken (and has been failing since)
https://source.cloud.google.com/results/invocations/53e39cd8-0d19-4f6e-a06c-d81f72a0c8e2/log

@jtattermusch
Copy link
Contributor Author

The diff from piper import seems to be reverting some of the python's setup.py changes introduced by #8280 (and those changes are necessary for generating the aarch64 wheels).

added by the aarch64 PR:
https://github.com/protocolbuffers/protobuf/pull/8280/files#diff-eb8b42d9346d0a5d371facf21a8bfa2d16fb49e213ae7c21f03863accebe0fcf

and seems to be removed by the piper import diff:
998d3a3...636132b#diff-eb8b42d9346d0a5d371facf21a8bfa2d16fb49e213ae7c21f03863accebe0fcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants