Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce setup.py changes from #8280 erased by piper import #8617 #8746

Merged

Conversation

jtattermusch
Copy link
Contributor

Fixes #8667.

For an unknown reason (am I missing something?), setup.py changes from #8280 have been erased by piper import #8617 (see #8667 (comment)).

These changes are actually necessary for correct build of aarch64 python wheels.
without them, the aarch64 wheels will have python extension .so files with wrong arch suffix x86_64-linux-gnu.so,
which results in failing to load the python C++ extension.
This is also basically what the broken tests reported by #8667 have detected.

This PR fixes the problem - as proven by a green adhoc run of the kokoro job (https://fusion2.corp.google.com/invocations/c1e5e71e-e779-48e7-8f0a-23b1d33a06b0/targets/protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython_aarch64%2Fcontinuous/log)

One thing I haven't been able to explain is:

  • why did the piper import erase the changes made to setup.py (was that intentional or perhaps a bad merge?)
  • was there any other important changes that ended up being deleted?

@jtattermusch
Copy link
Contributor Author

Test failures seem unrelated, I'm going to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python aarch64 linux tests broken by recent piper import
4 participants