Fix building packaged PHP extension #9727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test introduced in feef319 fails as expected |
|
After merging this we will need to cherry pick it back to the 3.20 line |
mkruskal-google
approved these changes
Apr 4, 2022
|
Any ETA for a new release including this fix? |
mkruskal-google
added a commit
that referenced
this pull request
Apr 5, 2022
Fix building packaged PHP extension (cherry picked from commit 7f9901c)
|
I've cherrypicked this into 3.20.1-rc1, which will likely be released this week due to issues with 3.20.0 |
mkruskal-google
added a commit
that referenced
this pull request
Apr 7, 2022
* Fix NPE during encoding and add regression test for issue 9507. (cherry picked from commit 58e320a) * Implement `respond_to?` in RubyMessage (#9677) All synthetic methods implemented by `method_missing` are now supported by `respond_to?`. Fixes issue #9202. * Fix null pointer exceptions exposed by new regression tests. * Fix clear_ on oneofs so that it is safe to call repeatedly and so that respond_to? does not depend on whether the oneof is currently cleared. * Code cleanup: reenable more tests on JRuby. * Align JRuby behavior with CRuby by throwing a RuntimeError when attempting to assign to a oneof. (cherry picked from commit 8e7f936) * Update protobuf version * Merge pull request #9727 from mlocati/build-packaged-php-extension Fix building packaged PHP extension (cherry picked from commit 7f9901c) * Update protobuf version * Update changelogs for 3.20.1-rc1 Co-authored-by: Jason Lunn <jason.lunn@gmail.com> Co-authored-by: Jorg Brown <jorg.brown@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently had a couple of issues that prevented the PHP extension from being installed with pecl (see #9654 and #9724).
So, what about adding a GitHub Action that checks if the PHP extension can be built successfully?
In this PR I first add that test (which will fail), then I'll add the required changes to make it pass
Fix #9724