New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(6178): emit ruby enum as integer #11673
Conversation
Thanks for the contribution, @MQuy. Can you add the corresponding changes to the JRuby implementation? |
1163142
to
6348512
Compare
hi @JasonLunn, I added JRuby implementation for emitting enums as integers. It looks like the pipeline won't run except it is triggered from your side? |
This PR looks good. Would you be able to rebase it on main? Sorry for the trouble, you've caught us in the middle of a migration to GitHub Actions. |
a49e8c4
to
b87cc4e
Compare
I'm seeing errors in the tests:
|
b87cc4e
to
fe471cc
Compare
fe471cc
to
ee31aa3
Compare
@haberman, my bad, updated |
hi @haberman, @zhangskz and @JasonLunn, would love to have your updates on this feature. |
I do apologize for having to ask this of you again but could you please rebase one more time? Things appear to be stuck even though the PR has been approved. Thanks. |
ee31aa3
to
90f986a
Compare
@ericsalo no worry, I rebased. Can you trigger pipelines again and merge the pull request. Thank you |
hi @haberman, @zhangskz, @JasonLunn and @ericsalo is it possible that we include this feature in the next release? |
Since this was committed to the main branch, it will be present in the next release (4.23.x). |
Fixes #6178
enums_as_integers
to emit enum as integer value.