Add support for options in CRuby, JRuby and FFI #14594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uby' into add-support-for-options-in-ruby
JasonLunn
requested review from
ericsalo
and removed request for
a team and
ericsalo
…internal_deep_freeze` for JRuby message classes.
…ternal_deep_freeze` for FFI message classes.
Don't expose `internal_deep_freeze`, even as a private method.
…ertion specific to class instance.
Don't expose `internal_deep_freeze` under JRuby, even as private method.
JasonLunn
commented
Nov 7, 2023
haberman
requested changes
Nov 7, 2023
* Pass arena to glue functions. * Memoize `options` accessor. * Remove use of VLA.
* Adding test coverage for `FieldOptions` * Handle case where fields are not materialized until after `freeze`
JasonLunn
changed the title
haberman
approved these changes
Nov 8, 2023
haberman
requested changes
Nov 8, 2023
haberman
approved these changes
Nov 8, 2023
JasonLunn
added a commit
that referenced
this pull request
Nov 13, 2023
Rewrrte and extension of #12828, with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up. Also includes these unrelated fixes: * Removes code echo between `google/protobuf/repeated_field.rb` and `google/protobuf/ffi/repeated_field.rb` by `require`'ing the former in the latter. * Adds missing calles to `testFrozen()` from methods of `RepeatedField` under JRuby that mutate. * Various typos in comments. Closes #14594 COPYBARA_INTEGRATE_REVIEW=#14594 from protocolbuffers:add-support-for-options-in-ruby 16cc9e3 PiperOrigin-RevId: 580848874
zhangskz
pushed a commit
that referenced
this pull request
Nov 13, 2023
Rewrrte and extension of #12828, with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up. Also includes these unrelated fixes: * Removes code echo between `google/protobuf/repeated_field.rb` and `google/protobuf/ffi/repeated_field.rb` by `require`'ing the former in the latter. * Adds missing calles to `testFrozen()` from methods of `RepeatedField` under JRuby that mutate. * Various typos in comments. Closes #14594 COPYBARA_INTEGRATE_REVIEW=#14594 from protocolbuffers:add-support-for-options-in-ruby 16cc9e3 PiperOrigin-RevId: 580848874
zhangskz
added a commit
that referenced
this pull request
Nov 15, 2023
…4756) Follow up to #14594, which added support for custom options, this PR implements extensions support, which should fully resolve #1198. Closes #14703 COPYBARA_INTEGRATE_REVIEW=#14703 from protocolbuffers:add-support-for-extensions-in-ruby 601aca4 PiperOrigin-RevId: 582460674 Co-authored-by: Jason Lunn <jason.lunn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite and extension of #12828, with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up.
Also includes these unrelated fixes:
google/protobuf/repeated_field.rbandgoogle/protobuf/ffi/repeated_field.rbbyrequire'ing the former in the latter.testFrozen()from methods ofRepeatedFieldunder JRuby that mutate.