Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for options in CRuby, JRuby and FFI (#14594) #14739

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add support for options in CRuby, JRuby and FFI (#14594) #14739

merged 2 commits into from
Nov 13, 2023

Commits on Nov 13, 2023

  1. Add support for options in CRuby, JRuby and FFI (#14594) 

    Rewrrte and extension of #12828, with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up.

Also includes these unrelated fixes:
* Removes code echo between `google/protobuf/repeated_field.rb` and `google/protobuf/ffi/repeated_field.rb` by `require`'ing the former in the latter.
* Adds missing calles to `testFrozen()` from methods of `RepeatedField` under JRuby that mutate.
* Various typos in comments.

Closes #14594

COPYBARA_INTEGRATE_REVIEW=#14594 from protocolbuffers:add-support-for-options-in-ruby 16cc9e3
PiperOrigin-RevId: 580848874
    @JasonLunn
    JasonLunn committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b4e54cc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/25.x' into 25.x-with-ruby-opti… 

    …ons-support
    @JasonLunn
    JasonLunn committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    624a1ab View commit details
    Browse the repository at this point in the history