Add --fatal_warnings flag to treat warnings as errors #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a --fatal_warnings flag that requests that protoc exit with a failing status code if any warnings are generated during compilation. Partially address protocolbuffers#3980.
|
OK to test |
|
The appveyor test seems to be failing. Could you take a look? |
|
Whoops, I accidentally deleted part of an unrelated test in my original PR. Sorry about that. Please take another look! It should be fixed now. |
|
Hmm, the linux C++ tests are still failing. Did you test it in linux? I will try patch and see if I can reproduce the error in the presubmit. |
|
It seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --fatal_warnings flag that requests that protoc exit with a failing status code if any warnings are generated during compilation.
Partially address #3980.
/cc @pherl