New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll forward Ruby upb changes now that protobuf Ruby build is fixed #5866
Merged
Commits on Mar 11, 2019
-
Rolled forward again with "Updated upb from defcleanup branch..."
Revert "Revert "Updated upb from defcleanup branch and modified Ruby to use it (protocolbuffers#5539)" (protocolbuffers#5848)" This reverts commit 1568dea.
-
Commits on May 5, 2019
Commits on May 18, 2019
-
-
-
-
-
-
Set -std=gnu90 and fixed warnings/errors.
Some of our Kokoro tests seem to run with this level of warnings, and the source strives to be gnu90 compatible. Enforcing it for every build removes the possibility of some errors showing up in Kokoro/Travis tests only.
-
Fixed remaining warnings with gnu90 mode.
I tried to match warning flags with what Ruby appears to do in our Kokoro tests.
-
-
We need to initialize this marked value before creating the instance.
-
Commits on May 21, 2019
Commits on Jul 6, 2019
Commits on Aug 14, 2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.