Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Proto2 feature : Finale #5936

Merged
merged 34 commits into from Sep 3, 2019
Merged

C# Proto2 feature : Finale #5936

merged 34 commits into from Sep 3, 2019

Commits on Aug 23, 2019

  1. Remove internal constraint on descriptor proto

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    5caa44e View commit details
    Browse the repository at this point in the history

  2. Remove proto2 check from generator

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    4be0394 View commit details
    Browse the repository at this point in the history

  3. Reapply custom option accessors from previous PR along with CustomOpt… 

    …ions accessor deprecations
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    05712c6 View commit details
    Browse the repository at this point in the history

  4. Make extension container classes public and modify conformance to tes… 

    …t proto2 messages
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    0387204 View commit details
    Browse the repository at this point in the history

  5. Uncomment option code in OneofDescriptor

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    43619bb View commit details
    Browse the repository at this point in the history

  6. Add checks to make sure values retrieved from CustomOptions match ext… 

    …ension values
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    6e7c43f View commit details
    Browse the repository at this point in the history

  7. Add test protos to test project 

    Fix generated group code missing end group tag case
Fix generated field classes searching for presence index for extensions
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    8a57ec8 View commit details
    Browse the repository at this point in the history

  8. Fix incorrect code gen for string fields with default values

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    a976158 View commit details
    Browse the repository at this point in the history

  9. Add tests for field presence and default values 

    Adjust APIs for extensions to properly return default values for extensions
Fix issues with IsInitialized and proto2 field reflection
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    8b7fb7d View commit details
    Browse the repository at this point in the history

  10. Added FieldDescriptor.IsExtension and sealed ExtensionCollection

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    8e917d1 View commit details
    Browse the repository at this point in the history

  11. file descriptors and the syntax field are really weird with proto2

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    5b2f2c5 View commit details
    Browse the repository at this point in the history

  12. Fix issues from interactive rebase and regenerate code

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    011427c View commit details
    Browse the repository at this point in the history

  13. Added group roundtrip tests and fixed any issues discovered

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    cd65535 View commit details
    Browse the repository at this point in the history

  14. Change input message to UnknownFieldSet tests to proto2 test message … 

    …to test groups.
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    134242b View commit details
    Browse the repository at this point in the history

  15. Add private "_Extensions" property to speed up IsInitialized checks

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    ebf0bfa View commit details
    Browse the repository at this point in the history

  16. Fix RepeatedExtensionValue.IsInitialized

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    b78330b View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary check in GetIsExtensionsInitialized

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    8dc69ed View commit details
    Browse the repository at this point in the history

  18. Remove dead HasValue code for ExtensionValue and add null-checks to E… 

    …xtensionSet.Set
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    f4cfd2d View commit details
    Browse the repository at this point in the history

  19. Add ExtensionSet tests and add checks that non-message extension fiel… 

    …ds don't fail initialization checks
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    0c80570 View commit details
    Browse the repository at this point in the history

  20. Add tests for extension accessor

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    9163a6f View commit details
    Browse the repository at this point in the history

  21. Make extension reflection helper use GetOrRegisterExtension

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    bf4f6c5 View commit details
    Browse the repository at this point in the history

  22. Reorganize some tests

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    6b90ac1 View commit details
    Browse the repository at this point in the history

  23. Add missing files to Makefile.am

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    2b9d0fd View commit details
    Browse the repository at this point in the history

  24. Regenerate testprotos.pb

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    29d5186 View commit details
    Browse the repository at this point in the history

  25. Review changes 

     * Add Syntax enum and make file syntax checks check the enum
 * Made IsPacked a normal get method without ternary op
 * Moved IFieldAccessor.HasValue to IFieldPresenceAccessor
 * Change naming of GetIsExtensionsInitialized
 * Fixed stray text in summary text
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    47f2017 View commit details
    Browse the repository at this point in the history

  26. Fix default extension values being unused in FieldCodec

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    29141f4 View commit details
    Browse the repository at this point in the history

  27. Revert changes for FieldPresenceAccessor

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    930db67 View commit details
    Browse the repository at this point in the history

  28. Rename ExtensionRegistry.Add(IEnumerable<Extension>) overload to AddR… 

    …ange
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    3237ad3 View commit details
    Browse the repository at this point in the history

  29. Fix readability in FieldCodec.ForMessage/Group factories

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    79cf8a8 View commit details
    Browse the repository at this point in the history

  30. Fix comment on IExtendableMessage.GetOrRegisterExtension

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    c5fa0e0 View commit details
    Browse the repository at this point in the history

  31. GetOrRegisterExtension -> GetOrInitializeExtension 

    Add comment explaining IExtensionMessage instability
    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    0436b8d View commit details
    Browse the repository at this point in the history

  32. Add GeneratedMessageTest.Proto2.cs to EXTRA_DIST

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    6da14fa View commit details
    Browse the repository at this point in the history

  33. Expose Extension field in FieldDescriptor

    @ObsidianMinor
    ObsidianMinor committed Aug 23, 2019
    Copy the full SHA
    bdc6cd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Use proto2 and proto3 in unknown field tests

    @ObsidianMinor
    ObsidianMinor committed Aug 29, 2019
    Copy the full SHA
    4d5ae5b View commit details
    Browse the repository at this point in the history