Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update six version to 1.12.0 and fix legacy_create_init issue #6391

Merged
merged 3 commits into from Aug 15, 2019
Merged

Update six version to 1.12.0 and fix legacy_create_init issue #6391

merged 3 commits into from Aug 15, 2019

Commits on Aug 10, 2019

  1. Update six version to 1.12.0 and fix legacy_create_init issue 

    When the @six//:six library is used on a target without the
`legacy_create_init` flag disabled, the library will not be
usable due to __init__.py being empty and the six code will
be in six.py. This change forces six to occupy the __init__
name, preventing this file getting created regardless of
the `legacy_create_init` setting.

See comments on a74c43b for
context:
protocolbuffers@a74c43b
    @aaliddell
    aaliddell committed Aug 10, 2019
    Copy the full SHA
    b5fdba3 View commit details
    Browse the repository at this point in the history

  2. Move six.BUILD to third_party and update paths

    @aaliddell
    aaliddell committed Aug 10, 2019
    Copy the full SHA
    f0e5046 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate six http_archive definition 

    Archive is declared in the protobuf_deps() call above
    @aaliddell
    aaliddell committed Aug 10, 2019
    Copy the full SHA
    8a576ee View commit details
    Browse the repository at this point in the history