Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add csharp compatibility tests between last released and the current version #6407

Merged
merged 5 commits into from
Jul 25, 2019
Merged

Add csharp compatibility tests between last released and the current version #6407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62c522f
Add csharp compatibility tests for 3.7.0
anandolee Jul 18, 2019
69cb64a
Add compatibility test between last major version with current for C#
anandolee Jul 23, 2019
fa4befb
Update last version number
anandolee Jul 23, 2019
a6b42f4
compatibility tests between last released and the current version
anandolee Jul 24, 2019
0c28998
fix typo
anandolee Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions csharp/compatibility_tests/v3.0.0/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ case "$1" in
OLD_VERSION=3.1.0
OLD_VERSION_PROTOC=http://repo1.maven.org/maven2/com/google/protobuf/protoc/3.1.0/protoc-3.1.0-linux-x86_64.exe
;;
3.7.0)
OLD_VERSION=3.7.0
OLD_VERSION_PROTOC=http://repo1.maven.org/maven2/com/google/protobuf/protoc/3.7.0/protoc-3.7.0-linux-x86_64.exe
;;
*)
echo "[ERROR]: Unknown version number: $1"
exit 1
Expand Down
3 changes: 3 additions & 0 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ build_csharp() {

# Run csharp compatibility test between 3.0.0 and the current version.
csharp/compatibility_tests/v3.0.0/test.sh 3.0.0

# Run csharp compatibility test between 3.7.0 and the curretn version.
csharp/compatibility_tests/v3.0.0/test.sh 3.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just update 3.0.0 on line 149 to 3.7.0?

Copy link
Contributor Author

@anandolee anandolee Jul 23, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep two compatibility tests: one between a fixed very old version with current and another is last released version with current.

Have changed C# to use last released version instead of 3.7.0 here. Will try to change other languages later

}

build_golang() {
Expand Down