Fixed leap year handling by reworking upb_mktime() -> upb_timegm(). #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function name also better reflects the semantics of the function. Like timegm(), this function always converts to/from UTC, not local time.
TeBoring
reviewed
Sep 24, 2019
|
Could you send a change to 3.10.x? |
|
I'm happy to add conformance tests later, but this is a data loss bug that I want to fix now. We can add conformance tests after. |
|
Here is a PR against 3.10.x: #6695 |
|
Since the other PR has been merged to 3.10.x which will be merged back to master, this is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function name also better reflects the semantics of the
function. Like timegm(), this function always converts to/from
UTC, not local time.